-
-
Notifications
You must be signed in to change notification settings - Fork 489
[4.x] Add LogTenancyBootstrapper #1381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
01a06c9
96a05cd
43cf6d2
50853a3
b80d7b3
a13110c
718afd3
a806df0
ec47528
8cd35d3
62a0e39
582243c
bd44036
63bf4bf
81daa9d
42c837d
7bdbe9d
c180c2c
412c1d0
0b3f698
f878aaf
b36f3ce
108e0d1
e133c87
58a2447
ae39e4d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,140 @@ | ||||||||
| <?php | ||||||||
|
|
||||||||
| declare(strict_types=1); | ||||||||
|
|
||||||||
| namespace Stancl\Tenancy\Bootstrappers; | ||||||||
|
|
||||||||
| use Closure; | ||||||||
| use Illuminate\Contracts\Config\Repository as Config; | ||||||||
| use Illuminate\Log\LogManager; | ||||||||
| use Stancl\Tenancy\Contracts\TenancyBootstrapper; | ||||||||
| use Stancl\Tenancy\Contracts\Tenant; | ||||||||
|
|
||||||||
| /** | ||||||||
| * This bootstrapper makes it possible to configure tenant-specific logging. | ||||||||
| * | ||||||||
| * By default, the storage path channels ('single' and 'daily' by default, | ||||||||
| * but feel free to customize that using the $storagePathChannels property) | ||||||||
| * are configured to use tenant storage directories. | ||||||||
| * For this to work correctly, this bootstrapper must run *after* FilesystemTenancyBootstrapper. | ||||||||
| * FilesystemTenancyBootstrapper alters how storage_path() works in the tenant context. | ||||||||
| * | ||||||||
| * The bootstrapper also supports custom channel overrides via the $channelOverrides property (see the property's docblock). | ||||||||
| * | ||||||||
| * @see Stancl\Tenancy\Bootstrappers\FilesystemTenancyBootstrapper | ||||||||
| */ | ||||||||
| class LogTenancyBootstrapper implements TenancyBootstrapper | ||||||||
| { | ||||||||
| protected array $defaultConfig = []; | ||||||||
|
|
||||||||
| /** | ||||||||
| * Log channels that use the storage_path() helper for storing the logs. Requires FilesystemTenancyBootstrapper to run before this bootstrapper. | ||||||||
| * Or you can bypass this default behavior by using overrides, since they take precedence over the default behavior. | ||||||||
| */ | ||||||||
| public static array $storagePathChannels = ['single', 'daily']; | ||||||||
|
|
||||||||
| /** | ||||||||
| * Custom channel configuration overrides. | ||||||||
| * | ||||||||
| * Examples: | ||||||||
| * - Array mapping (the default approach): ['slack' => ['url' => 'webhookUrl']] maps $tenant->webhookUrl to slack.url (if $tenant->webhookUrl is not null, otherwise, the override is ignored) | ||||||||
| * - Closure: ['slack' => fn (Tenant $tenant, array $channel) => array_merge($channel, ['url' => $tenant->slackUrl])] | ||||||||
| */ | ||||||||
| public static array $channelOverrides = []; | ||||||||
|
|
||||||||
| public function __construct( | ||||||||
| protected Config $config, | ||||||||
| protected LogManager $logManager, | ||||||||
| ) {} | ||||||||
|
|
||||||||
| public function bootstrap(Tenant $tenant): void | ||||||||
| { | ||||||||
| $this->defaultConfig = $this->config->get('logging.channels'); | ||||||||
| $channels = $this->getChannels(); | ||||||||
|
|
||||||||
| $this->configureChannels($channels, $tenant); | ||||||||
| $this->forgetChannels($channels); | ||||||||
| } | ||||||||
|
|
||||||||
| public function revert(): void | ||||||||
| { | ||||||||
| $this->config->set('logging.channels', $this->defaultConfig); | ||||||||
|
|
||||||||
| $this->forgetChannels($this->getChannels()); | ||||||||
| } | ||||||||
|
|
||||||||
| /** | ||||||||
| * Channels to configure and re-resolve afterwards (including the channels in the log stack). | ||||||||
| */ | ||||||||
| protected function getChannels(): array | ||||||||
| { | ||||||||
| // Get the currently used (default) logging channel | ||||||||
| $defaultChannel = $this->config->get('logging.default'); | ||||||||
| $channelIsStack = $this->config->get("logging.channels.{$defaultChannel}.driver") === 'stack'; | ||||||||
|
|
||||||||
| // If the default channel is stack, also get all the channels it contains. | ||||||||
| // The stack channel also has to be included in the list of channels | ||||||||
| // since the channel will be resolved and saved in the log manager, | ||||||||
| // and its config could accidentally be used instead of the underlying channels. | ||||||||
| // | ||||||||
| // For example, when you use 'stack' with the 'slack' channel and you want to configure the webhook URL, | ||||||||
| // both the 'stack' and the 'slack' must be re-resolved after updating the config for the channels to use the correct webhook URLs. | ||||||||
| // If only one of the mentioned channels would be re-resolved, the other's webhook URL would be used for logging. | ||||||||
| $channels = $channelIsStack | ||||||||
| ? [$defaultChannel, ...$this->config->get("logging.channels.{$defaultChannel}.channels")] | ||||||||
| : [$defaultChannel]; | ||||||||
|
|
||||||||
| return $channels; | ||||||||
| } | ||||||||
|
|
||||||||
| /** | ||||||||
| * Configure channels for the tenant context. | ||||||||
| * | ||||||||
| * Only the channels that are in the $storagePathChannels array | ||||||||
| * or have custom overrides in the $channelOverrides property | ||||||||
| * will be configured. | ||||||||
| */ | ||||||||
| protected function configureChannels(array $channels, Tenant $tenant): void | ||||||||
| { | ||||||||
| foreach ($channels as $channel) { | ||||||||
| if (isset(static::$channelOverrides[$channel])) { | ||||||||
| $this->overrideChannelConfig($channel, static::$channelOverrides[$channel], $tenant); | ||||||||
| } elseif (in_array($channel, static::$storagePathChannels)) { | ||||||||
| // Set storage path channels to use tenant-specific directory (default behavior) | ||||||||
| // The tenant log will be located at e.g. "storage/tenant{$tenantKey}/logs/laravel.log" (assuming FilesystemTenancyBootstrapper is used before this bootstrapper) | ||||||||
| $this->config->set("logging.channels.{$channel}.path", storage_path('logs/laravel.log')); | ||||||||
|
||||||||
| $this->config->set("logging.channels.{$channel}.path", storage_path('logs/laravel.log')); | |
| $logFilename = $this->getTenantLogFilename($tenant); | |
| $this->config->set("logging.channels.{$channel}.path", storage_path("logs/{$logFilename}")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, this is fine for the default behavior, it can still be customized. Resolving this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of the box, if no customization is used, $storagePathChannels includes daily which does not use laravel.log names, but day-specific names. Seems like something that should be checked and tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is checked and tested already, I'd just add a short comment with an explanation of how daily works.
daily driver uses RotatingFileHandler that parses the file name. The current code (= storage_path('logs/laravel.log')) corresponds to the daily log channel config. It is correct, so I'd just clarify this since this can indeed be quite confusing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the key in this array is e.g.
slack, and we can provide either a "partial array override" or a closure that returns the override dynamically based on$tenant, why would the closure approach be:As opposed to returning a value that'd directly override the channel:
The current approach would let you do for instance
$channelOverrides['foo'] = fn ($config, $tenant) => $config->set('bar', ...)which doesn't make sense. And requiring the user to do$config->set()manually in the first place is unnecessary complexity for the user.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be resolved now f878aaf
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swapped the parameter order. Example for current usage of overrides:
Also updated the comments to clarify the bootstrapper's behavior. So I think this review can be resolved now