Define STRFTIME/MOMENT/MOMENT-MS/RSS-DATE#163
Define STRFTIME/MOMENT/MOMENT-MS/RSS-DATE#163shawwn wants to merge 3 commits intoarclanguage:masterfrom
Conversation
|
I wanted to get another set of eyes on this before merging. |
|
My eyes are not very useful when there aren't tests to run. But these are new functions so no worries. I assume you're running them in laarc? Please remember to backport bugfixes as you run into them. Oh also, it may be convenient to add some |
| "Converts 'x' into a symbol." | ||
| (coerce x 'sym)) | ||
|
|
||
| (def str (x) |
There was a problem hiding this comment.
Possibly. (coerce x 'string) behaves differently from (+ "" x).
There was a problem hiding this comment.
In no situations. Never mind, I was mistaken. :)
One benefit of adding a str function is that it can be a place to do things like printing a hash table using curly brace syntax. But that's work for some other time. I'll get rid of str.
There was a problem hiding this comment.
Also, feel free to overload string for those purposes.
(I don't particularly what the function is called. But it seems good to have one strong default.)
Yup! Previously I was shelling out to
No need to port bug fixes when the code is flawless. /s (Good point! I'll be sure to port any fixes that come up.)
Good idea! |
(Also define
strandleftpad)