Add per-host capability to shell plugin#24
Add per-host capability to shell plugin#24kbuley wants to merge 3 commits intoarcticicestudio:developfrom
Conversation
Currently, any configured script will execute on all hosts. This commit will allow for a host item in the config so that the script will only run on the specific host. A hostname of "-" will match all hosts. For backwards compatibility, a config with no host specified will run on all hosts.
…ley/snowsaw into feature/shell-per-host-config
|
Sorry for the long delay, haven't got the time to test and review the changes yet, but I'll definitely check it until next weekend. ⌚ |
|
Too funny, I was literally just thinking about this. I got this notification about 10 seconds after I cd'd into my snowblocks directory to add something. |
There was a problem hiding this comment.
I think we should change the implementation to match the hosts option of the link plugin added in #22.
A single host string would limit the command to a single host. If users like to run the command on more than one specific host they need to add the same command multiple times with a different host string.
It should be fine to have duplicated code in the link and shell core plugins for the moment since I thought about making the hosts option part of the base Plugin class to make it available for every plugin.
Let me know what you think about this change.
2 participants
Currently, any configured script will execute on all hosts. This commit
will allow for a host item in the config so that the script will only
run on the specific host. A hostname of "-" will match all hosts. For
backwards compatibility, a config with no host specified will run
on all hosts.