Optimize reflection dependency in SmartEnum List property for performance-sensitive scenarios #567
Open
mokarchi wants to merge 1 commit intoardalis:mainfrom
Open
Optimize reflection dependency in SmartEnum List property for performance-sensitive scenarios #567mokarchi wants to merge 1 commit intoardalis:mainfrom
mokarchi wants to merge 1 commit intoardalis:mainfrom
Conversation
Refactored lazy initialization to use a thread-safe `Lazy<List<TEnum>> _enumOptions` for caching enum options, reducing redundant calls to `GetAllOptions()`. Updated related methods and properties to leverage the cached options. Changed the return type of `GetAllOptions` to `List<TEnum>` for better performance. Simplified the `List` property to directly use the cached options. Introduced a `ConcurrentDictionary` in `TypeExtensions` to cache results of `GetFieldsOfType<TFieldType>`, minimizing reflection overhead. Performed code cleanup, improved formatting, adjusted `using` directives, and ensured thread-safety with `LazyThreadSafetyMode.ExecutionAndPublication`.
Author
|
@ardalis Could you review this, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes the reflection dependency through strategic caching improvements:
SmartFlagEnum Optimization
static readonly Lazy<List<TEnum>> _enumOptionsfield to match the efficiency ofSmartEnum_fromName.Value.Values.ToList().AsReadOnly()to direct cached accessFromValue(),DeserializeValue(),TryFromValue(), andFromValueToString()methods to use cached data instead of callingGetAllOptions()repeatedlyType-Level Reflection Caching
Enhanced
TypeExtensions.GetFieldsOfType<T>()withConcurrentDictionary<Type, object>caching to prevent repeated reflection operations on the same type across different instances.Backward Compatibility