Cleanup

[fiseni]

No description provided.

[Copilot]

Pull Request Overview

This PR performs code cleanup by renaming a constant, removing unused code, hiding packaging assets, and reordering/removing unused members.

• Rename private _forceDocker constant to FORCE_DOCKER and update its usages.
• Remove unused var spec declarations in SearchExtensionTests.
• Hide package assets (icon.png, readme-nuget.md, LICENSE) in the build props and tidy up internal members in the specification classes.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/Ardalis.Specification.EntityFrameworkCore.Tests/Fixture/TestFactory.cs	Renamed _forceDocker constant to FORCE_DOCKER and updated its references
tests/Ardalis.Specification.EntityFrameworkCore.Tests/Evaluators/SearchExtensionTests.cs	Removed unused var spec lines
src/Directory.Build.props	Added Visible="false" to packaging assets
src/Ardalis.Specification/Specification.cs	Removed dead-code const and reordered internal members
src/Ardalis.Specification.EntityFrameworkCore/Evaluators/SpecificationEvaluator.cs	Swapped explicit null-check to ArgumentNullException.ThrowIfNull

Comments suppressed due to low confidence (1)

tests/Ardalis.Specification.EntityFrameworkCore.Tests/Fixture/TestFactory.cs:10

• [nitpick] Use PascalCase for private constants per .NET conventions (e.g., rename to ForceDocker) instead of all-caps with underscores.

private const bool FORCE_DOCKER = false;