Fix of memory leak happening on realloc fails

[Amphyby]

https://en.cppreference.com/w/c/memory/realloc

Initially investigated the behaviour of it as I faced (supposingly) crashes on my Arduino Uno R4 Wifi acting as central device, reading characteristic from peripheral device on subscription basis. At some point it just stops receiving new values, despite through Nordic Semiconductor app on Android I am able to subscribe to same characteristic and receive new values without interruptions.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 15.25%. Comparing base (2beed7b) to head (6e79635).

Files with missing lines	Patch %	Lines
src/remote/BLERemoteCharacteristic.cpp	0.00%	17 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
- Coverage   15.26%   15.25%   -0.02%     
==========================================
  Files          29       29              
  Lines        3681     3685       +4     
==========================================
  Hits          562      562              
- Misses       3119     3123       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

Memory usage change @ 6e79635

Board	flash	%	RAM for global variables	%
arduino:esp32:nano_nora	❔ -4 - +8	-0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed_giga:giga	🔺 0 - +64	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed_nano:nano33ble	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed_nano:nanorp2040connect	🔺 +4 - +12	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed_nicla:nicla_vision	🔺 0 - +64	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed_opta:opta	🔺 0 - +64	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed_portenta:envie_m7	N/A	N/A	N/A	N/A
arduino:megaavr:uno2018:mode=on	🔺 +12 - +26	+0.02 - +0.05	0 - 0	0.0 - 0.0
arduino:renesas_portenta:portenta_c33	🔺 +8 - +8	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:renesas_uno:unor4wifi	🔺 0 - +16	0.0 - +0.01	0 - 0	0.0 - 0.0
arduino:samd:mkrwifi1010	🔺 0 - +16	0.0 - +0.01	0 - 0	0.0 - 0.0
arduino:samd:nano_33_iot	🔺 0 - +16	0.0 - +0.01	0 - 0	0.0 - 0.0
arduino:zephyr:unoq	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:zephyr_main:giga	🔺 0 - +4	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:zephyr_main:nano33ble	🔺 0 - +4	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:zephyr_main:opta	🔺 0 - +4	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:zephyr_main:portentac33	🔺 0 - +4	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:zephyr_main:portentah7	🔺 0 - +4	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	examples/Central/LedControl flash	%	examples/Central/LedControl RAM for global variables	%	examples/Central/PeripheralExplorer flash	%	examples/Central/PeripheralExplorer RAM for global variables	%	examples/Central/Scan flash	%	examples/Central/Scan RAM for global variables	%	examples/Central/ScanCallback flash	%	examples/Central/ScanCallback RAM for global variables	%	examples/Central/SensorTagButton flash	%	examples/Central/SensorTagButton RAM for global variables	%	examples/Peripheral/Advertising/EnhancedAdvertising flash	%	examples/Peripheral/Advertising/EnhancedAdvertising RAM for global variables	%	examples/Peripheral/Advertising/RawDataAdvertising flash	%	examples/Peripheral/Advertising/RawDataAdvertising RAM for global variables	%	examples/Peripheral/BatteryMonitor flash	%	examples/Peripheral/BatteryMonitor RAM for global variables	%	examples/Peripheral/ButtonLED flash	%	examples/Peripheral/ButtonLED RAM for global variables	%	examples/Peripheral/CallbackLED flash	%	examples/Peripheral/CallbackLED RAM for global variables	%	examples/Peripheral/EncryptedBatteryMonitor flash	%	examples/Peripheral/EncryptedBatteryMonitor RAM for global variables	%	examples/Peripheral/LED flash	%	examples/Peripheral/LED RAM for global variables	%
arduino:esp32:nano_nora	-4	-0.0	0	0.0	8	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	8	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0
arduino:mbed_giga:giga	64	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	64	0.0	0	0.0
arduino:mbed_nano:nano33ble	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:mbed_nano:nanorp2040connect	4	0.0	0	0.0	12	0.0	0	0.0	4	0.0	0	0.0	4	0.0	0	0.0	12	0.0	0	0.0	4	0.0	0	0.0	4	0.0	0	0.0	4	0.0	0	0.0	4	0.0	0	0.0	4	0.0	0	0.0	4	0.0	0	0.0	4	0.0	0	0.0
arduino:mbed_nicla:nicla_vision	0	0.0	0	0.0	0	0.0	0	0.0	64	0.0	0	0.0	0	0.0	0	0.0	64	0.0	0	0.0	64	0.0	0	0.0	0	0.0	0	0.0	64	0.0	0	0.0	64	0.0	0	0.0	64	0.0	0	0.0	64	0.0	0	0.0	0	0.0	0	0.0
arduino:mbed_opta:opta	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	64	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:mbed_portenta:envie_m7	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A
arduino:megaavr:uno2018:mode=on	14	0.03	0	0.0	26	0.05	0	0.0	14	0.03	0	0.0	14	0.03	0	0.0	20	0.04	0	0.0	12	0.02	0	0.0	12	0.02	0	0.0	14	0.03	0	0.0	14	0.03	0	0.0	14	0.03	0	0.0	14	0.03	0	0.0	14	0.03	0	0.0
arduino:renesas_portenta:portenta_c33	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0
arduino:renesas_uno:unor4wifi	16	0.01	0	0.0	16	0.01	0	0.0	0	0.0	0	0.0	16	0.01	0	0.0	16	0.01	0	0.0	16	0.01	0	0.0	16	0.01	0	0.0	16	0.01	0	0.0	16	0.01	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	16	0.01	0	0.0
arduino:samd:mkrwifi1010	0	0.0	0	0.0	16	0.01	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0
arduino:samd:nano_33_iot	0	0.0	0	0.0	16	0.01	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	8	0.0	0	0.0	8	0.0	0	0.0
arduino:zephyr:unoq	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:zephyr_main:giga	0	0.0	0	0.0	4	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	4	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:zephyr_main:nano33ble	0	0.0	0	0.0	4	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	4	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:zephyr_main:opta	0	0.0	0	0.0	4	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	4	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:zephyr_main:portentac33	0	0.0	0	0.0	4	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	4	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:zephyr_main:portentah7	0	0.0	0	0.0	4	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	4	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0

Click for full report CSV

Board,examples/Central/LedControl<br>flash,%,examples/Central/LedControl<br>RAM for global variables,%,examples/Central/PeripheralExplorer<br>flash,%,examples/Central/PeripheralExplorer<br>RAM for global variables,%,examples/Central/Scan<br>flash,%,examples/Central/Scan<br>RAM for global variables,%,examples/Central/ScanCallback<br>flash,%,examples/Central/ScanCallback<br>RAM for global variables,%,examples/Central/SensorTagButton<br>flash,%,examples/Central/SensorTagButton<br>RAM for global variables,%,examples/Peripheral/Advertising/EnhancedAdvertising<br>flash,%,examples/Peripheral/Advertising/EnhancedAdvertising<br>RAM for global variables,%,examples/Peripheral/Advertising/RawDataAdvertising<br>flash,%,examples/Peripheral/Advertising/RawDataAdvertising<br>RAM for global variables,%,examples/Peripheral/BatteryMonitor<br>flash,%,examples/Peripheral/BatteryMonitor<br>RAM for global variables,%,examples/Peripheral/ButtonLED<br>flash,%,examples/Peripheral/ButtonLED<br>RAM for global variables,%,examples/Peripheral/CallbackLED<br>flash,%,examples/Peripheral/CallbackLED<br>RAM for global variables,%,examples/Peripheral/EncryptedBatteryMonitor<br>flash,%,examples/Peripheral/EncryptedBatteryMonitor<br>RAM for global variables,%,examples/Peripheral/LED<br>flash,%,examples/Peripheral/LED<br>RAM for global variables,%
arduino:esp32:nano_nora,-4,-0.0,0,0.0,8,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,8,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0
arduino:mbed_giga:giga,64,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,64,0.0,0,0.0
arduino:mbed_nano:nano33ble,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,4,0.0,0,0.0,12,0.0,0,0.0,4,0.0,0,0.0,4,0.0,0,0.0,12,0.0,0,0.0,4,0.0,0,0.0,4,0.0,0,0.0,4,0.0,0,0.0,4,0.0,0,0.0,4,0.0,0,0.0,4,0.0,0,0.0,4,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,0,0.0,0,0.0,0,0.0,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_opta:opta,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:megaavr:uno2018:mode=on,14,0.03,0,0.0,26,0.05,0,0.0,14,0.03,0,0.0,14,0.03,0,0.0,20,0.04,0,0.0,12,0.02,0,0.0,12,0.02,0,0.0,14,0.03,0,0.0,14,0.03,0,0.0,14,0.03,0,0.0,14,0.03,0,0.0,14,0.03,0,0.0
arduino:renesas_portenta:portenta_c33,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0
arduino:renesas_uno:unor4wifi,16,0.01,0,0.0,16,0.01,0,0.0,0,0.0,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,16,0.01,0,0.0
arduino:samd:mkrwifi1010,0,0.0,0,0.0,16,0.01,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0
arduino:samd:nano_33_iot,0,0.0,0,0.0,16,0.01,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0
arduino:zephyr:unoq,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:zephyr_main:giga,0,0.0,0,0.0,4,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,4,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:zephyr_main:nano33ble,0,0.0,0,0.0,4,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,4,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:zephyr_main:opta,0,0.0,0,0.0,4,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,4,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:zephyr_main:portentac33,0,0.0,0,0.0,4,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,4,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:zephyr_main:portentah7,0,0.0,0,0.0,4,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,4,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0