Skip to content

Fix time validity check to account for maximum possible timezone offset #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix time validity check to account for maximum possible timezone offset #507

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1fc512
fix time validity check
kytpbs Aug 23, 2024
14eff91
Improve comment
kytpbs Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/utility/time/TimeService.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,10 @@ unsigned long TimeServiceClass::getRemoteTime()

bool TimeServiceClass::isTimeValid(unsigned long const time)
{
return (time > EPOCH_AT_COMPILE_TIME);
/* EPOCH_AT_COMPILE_TIME is in local time, so we need to subtract the maximum
* possible timezone offset UTC+14 to make sure we are less then UTC time
*/
return (time > (EPOCH_AT_COMPILE_TIME - (14 * 60 * 60)));
}

bool TimeServiceClass::isTimeZoneOffsetValid(long const offset)
Expand Down
Loading