Skip to content

Explicitly handle NAN values #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 18, 2025
Merged

Explicitly handle NAN values #539

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
84de29f
Explicitly handle NAN values
sebromero Apr 7, 2025
c383fd7
Handle NaN values in CloudFloat comparison
sebromero Apr 7, 2025
706ffdc
Add test case for CloudFloat
sebromero Apr 9, 2025
9fa6a11
Improved and generalized ieee754 is different function
andreagilardoni Apr 9, 2025
9c2aaef
Add test for CloudWrapperFloat
sebromero Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/property/types/CloudWrapperFloat.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,10 @@ class CloudWrapperFloat : public CloudWrapperBase {
public:
CloudWrapperFloat(float& v) : _primitive_value(v), _cloud_value(v), _local_value(v) {}
virtual bool isDifferentFromCloud() {
return _primitive_value != _cloud_value && (abs(_primitive_value - _cloud_value) >= Property::_min_delta_property);
if (std::isnan(_primitive_value) || std::isnan(_cloud_value)) {
return std::isnan(_primitive_value) != std::isnan(_cloud_value);
}
return _primitive_value != _cloud_value && fabs(_primitive_value - _cloud_value) >= Property::_min_delta_property;
}
virtual void fromCloudToLocal() {
_primitive_value = _cloud_value;
Expand Down
Loading