Correct licensing documentation #54
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library is based on a C implementation of the Madgwick AHRS algorithm provided by Sebastian Madgwick. Unfortunately the licensing of that base code was not well documented. The licensing was only specified on the website of Sebastian Madgwick's x-io Technologies website where the code is hosted. Since this important information was difficult to find, a comment was added to the source code headers which contains a reference link and quote of the relevant statement. There were two serious problems with that comment: * The information was later removed from the linked page. * The quote did not include the essential link which clarifies exactly which version of the GPL license is offered. These are resolved by: * Using a link to an archived version of the reference web page which still provides the licensing information. * Adding markup to indicate the link in the quoted statement. Since that link relies on a redirect, an archive link is also used here in order to avoid future bit rot.
The project's readme contains a "License" section which summarizes the project licensing. Previously the information was incorrect (it seems to just be a copy/paste of the content that was present in most of Arduino's libraries at that time, by someone who didn't actually verify that it was appropriate): * The copyright assignment for Sebastian Madgwick, the author of the code upon which the library is based was omitted, falsely indicating that Arduino LLC is the sole copyright holder. * It stated that the project is licensed as LGPL 2.1, when it is actually the GPL 3.0 licensing inherited from the base code. The missing copyright assignment is hereby added and the license information corrected.
per1234
added
type: imperfection
|
Memory usage change @ bbd3e48
Click for full report table
Click for full report CSV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project's readme contains a "License" section which summarizes the project licensing.
Previously the information was incorrect (it seems to just be a copy/paste of the content that was present in most of Arduino's libraries at that time, by someone who didn't actually verify that it was appropriate):
The missing copyright assignment is hereby added and the license information corrected.
The text of the license summary is the standard license header for the project's GPL 3.0 license:
https://spdx.org/licenses/GPL-3.0-only.html#licenseHeader