Fix epoch time by removing user offset#43
Open
petslane wants to merge 1 commit intoarduino-libraries:masterfrom
Open
Fix epoch time by removing user offset#43petslane wants to merge 1 commit intoarduino-libraries:masterfrom
petslane wants to merge 1 commit intoarduino-libraries:masterfrom
Conversation
|
Can this be merged? the epoch time is wrong as it currently is |
Contributor
|
Hi @petslane 👋
unsigned long getUnixEpochTime() const; /* Returns the true unix epoch time without time offset */
unsigned long getUnixEpochTimeWithOffset() const { return getEpochTime(); }
unsigned long getEpochTime() const __attribute__ ((deprecated));
|
Nora465
added a commit
to Nora465/NTPClient
that referenced
this pull request
Nov 4, 2020
Fix the epoch time by removing the time offset (by user) Come from PR#43 : arduino-libraries#43
|
Peeter Normak seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
|
There is an alternative proposal at #227 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getEpochTime()should return epoch time that does not include offsets.User offset is included in methods returning local times -
getDay(),getHours(),getMinutes(),getSeconds(),getFormattedTime().Fixes #35