Skip to content

Reducing excessive I2C timeout #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Reducing excessive I2C timeout #494

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
265d24c
Reducing excessive I2C communication timeout (added however the possi…
maidnl Sep 23, 2025
bb58da9
Added short comment on function
maidnl Sep 23, 2025
4f15d9d
Renamed Wire timeout function
maidnl Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions libraries/Wire/Wire.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ TwoWire::TwoWire(int scl, int sda, WireAddressMode_t am /*= ADDRESS_MODE_7_BITS*
is_master(true),
is_sci(false),
address_mode(am),
timeout(1000),
timeout(1),
transmission_begun(false),
data_too_long(false),
rx_index(0),
Expand Down Expand Up @@ -835,7 +835,11 @@ void TwoWire::flush(void) {
while(bus_status != WIRE_STATUS_TX_COMPLETED && bus_status != WIRE_STATUS_TRANSACTION_ABORTED) {}
}


/* -------------------------------------------------------------------------- */
void TwoWire::setTimeout(unsigned int t) {
/* -------------------------------------------------------------------------- */
timeout = t;
}


#if WIRE_HOWMANY > 0
Expand Down
2 changes: 2 additions & 0 deletions libraries/Wire/Wire.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@ class TwoWire : public arduino::HardwareI2C {
void onRequest( void (*)(void) );

void setBusStatus(WireStatus_t);
/* set timeout in ms for I2C communication */
void setTimeout(unsigned int t);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this has an equivalent purpose to the AVR Wire library's setWireTimeout function:

https://github.com/arduino/ArduinoCore-avr/blob/855ea0100ba0f6b9036a19a6e71517125473b014/libraries/Wire/src/Wire.cpp#L90-L115

then please be consistent with the already well established API:

https://github.com/arduino/ArduinoCore-avr/blob/855ea0100ba0f6b9036a19a6e71517125473b014/libraries/Wire/src/Wire.h#L58


inline size_t write(unsigned long n) { return write((uint8_t)n); }
inline size_t write(long n) { return write((uint8_t)n); }
Expand Down
Loading