Portenta C33: fix Sketch upload #39
pennamcheckpatch.yml
on: pull_request
checkpatch review
9s
Annotations
10 errors
|
checkpatch review
WARNING: Missing commit description - Add an appropriate one
|
|
checkpatch review
ERROR: Missing Signed-off-by: line(s)
|
|
checkpatch review:
loader/main.c#L53
WARNING: braces {} are not necessary for single statement blocks
|
|
checkpatch review:
loader/main.c#L48
WARNING: braces {} are not necessary for single statement blocks
|
|
checkpatch review:
loader/main.c#L48
WARNING: Missing a blank line after declarations
|
|
checkpatch review:
loader/main.c#L36
WARNING: line length of 132 exceeds 100 columns
|
|
checkpatch review:
cores/arduino/SerialUSB.h#L43
ERROR: Bad function definition - int usb_disable() should probably be int usb_disable(void)
|
|
checkpatch review:
cores/arduino/SerialUSB.h#L41
ERROR: Bad function definition - int enable_usb_device_next() should probably be int enable_usb_device_next(void)
|
|
checkpatch review:
cores/arduino/SerialUSB.h#L41
WARNING: Missing a blank line after declarations
|
|
checkpatch review
WARNING: Missing commit description - Add an appropriate one
|