Add suggestions when a wrong FQBN is provided (installed platforms only)#1367
Open
facchinm wants to merge 1 commit intoarduino:masterfrom
Open
Add suggestions when a wrong FQBN is provided (installed platforms only)#1367facchinm wants to merge 1 commit intoarduino:masterfrom
facchinm wants to merge 1 commit intoarduino:masterfrom
Conversation
silvanocerza
suggested changes
Jul 26, 2021
Contributor
silvanocerza
left a comment
There was a problem hiding this comment.
I like the improvement but I think some things could still be enhanced.
ee76f7b to
771583d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)This PR tries to ease one of the pain points when dealing with the cli without fqbn autocompletion (fat fingers).
If the fqbn is wrong, try to find the closest match between installed platforms and suggest it to the interactive user.
No suggestion is given, and finding what is actually causing the error can be daunting
A suggestion is provided, for example:
titled accordingly?
Fixes #1366
See how to contribute