refactoring: implement a proper dependency (.d) file parser #2972
+1,483
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
added
type: enhancement
cmaglie
force-pushed
the
dep_file_parser
branch
2 times, most recently
from
04aafb3 to
afc0826
Compare
cmaglie
force-pushed
the
dep_file_parser
branch
from
afc0826 to
ce2aa2a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2972 +/- ##
=========================================
Coverage ? 68.31%
=========================================
Files ? 242
Lines ? 22743
Branches ? 0
=========================================
Hits ? 15538
Misses ? 6007
Partials ? 1198
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cmaglie
force-pushed
the
dep_file_parser
branch
from
ce2aa2a to
18ae29d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Refactor the dep (.d) file parser to handle more cases, and refine the subroutine API.
What is the current behavior?
No changes.
What is the new behavior?
No changes.
Does this PR introduce a breaking change, and is titled accordingly?
No.
Other information