Fix missing line break on invalid library message#3084
Open
Psykii22 wants to merge 4 commits intoarduino:masterfrom
Open
Fix missing line break on invalid library message#3084Psykii22 wants to merge 4 commits intoarduino:masterfrom
Psykii22 wants to merge 4 commits intoarduino:masterfrom
Conversation
When multiple invalid libraries were found during verbose compilation, the warning messages were printed without newlines between them. Added newline character after status.Message() in detector.go Fixes arduino#3039
|
|
per1234
added
topic: code
Author
|
@per1234 sir as I'm first time contributing in oss so how much time it will take to merge the pr if its merge-able, and if its not then why. If you can tell me it would be very helpful. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3084 +/- ##
==========================================
+ Coverage 69.56% 69.57% +0.01%
==========================================
Files 253 253
Lines 19280 19280
==========================================
+ Hits 13412 13414 +2
+ Misses 4629 4628 -1
+ Partials 1239 1238 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple invalid libraries were found during verbose compilation, the warning messages were printed without newlines between them.
Added newline character after status.Message() in detector.go
Fixes #3039
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When multiple invalid libraries (e.g., empty folders without header files) are found during verbose compilation, all warning messages are printed on the same line without newlines:
Issue: #3039
What is the new behavior?
Each warning message is now printed on its own line:
Does this PR introduce a breaking change, and is titled accordingly?
No, this is a non-breaking bug fix. It only affects the formatting of verbose output.
Other information
+ "\n"afterstatus.Message()indetector.goline 630