Skip to content

Conversation

@per1234
Copy link
Contributor

@per1234 per1234 commented Sep 11, 2025

Shell scripts in Arduino tooling projects are formatted according to the style implemented by the shfmt formatting tool.

In addition to standalone script files, significant quantities of complex shell code is also found in the asset tasks and workflows. shfmt can not be used to format this code (both due to the fact it is in the form of strings in YAML documents, and due to the fact that it is actually templates of shell code (making use of the templating features of Task and GitHub Actions) rather than complete shell code). However, it still makes sense to align the formatting of this code with the standardized shell code style where doing so is feasible.

Shell scripts in Arduino tooling projects are formatted according to the style implemented by the shfmt formatting tool.

In addition to standalone script files, significant quantities of complex shell code is also found in the asset tasks
and workflows. shfmt can not be used to format this code (both due to the fact it is in the form of strings in YAML
documents, and due to the fact that it is actually templates of shell code (making use of the templating features of
Task and GitHub Actions) rather than complete shell code). However, it still makes sense to align the formatting of this
code with the standardized shell code style where doing so is feasible.
@per1234 per1234 self-assigned this Sep 11, 2025
@per1234 per1234 added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Sep 11, 2025
@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.33%. Comparing base (fe2acf1) to head (ec3b935).
⚠️ Report is 8 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (fe2acf1) and HEAD (ec3b935). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (fe2acf1) HEAD (ec3b935)
unit 2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #926      +/-   ##
==========================================
- Coverage   89.91%   83.33%   -6.59%     
==========================================
  Files          44        1      -43     
  Lines        6813      180    -6633     
==========================================
- Hits         6126      150    -5976     
+ Misses        559       19     -540     
+ Partials      128       11     -117     
Flag Coverage Δ
unit 83.33% <ø> (-6.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@per1234 per1234 merged commit db613c1 into arduino:main Sep 11, 2025
75 of 88 checks passed
@per1234 per1234 deleted the shfmt branch September 14, 2025 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant