Automatic Library Installation from depends field in library.properties#205
Open
aliphys wants to merge 25 commits intoarduino:mainfrom
Open
Automatic Library Installation from depends field in library.properties#205aliphys wants to merge 25 commits intoarduino:mainfrom
depends field in library.properties#205aliphys wants to merge 25 commits intoarduino:mainfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
==========================================
- Coverage 99.81% 99.75% -0.06%
==========================================
Files 2 2
Lines 1608 1665 +57
==========================================
+ Hits 1605 1661 +56
- Misses 3 4 +1 ☔ View full report in Codecov by Sentry. |
Author
|
@per1234 Can you approve this PR? |
per1234
requested changes
Dec 7, 2023
Collaborator
per1234
left a comment
There was a problem hiding this comment.
Please add unit test coverage for the added code.
Author
|
Author
|
There is an error in one workflow, which I don't think is related to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the limitation described by @per1234 in arduino-libraries/Arduino_UnifiedStorage#30 (review)
Currently, the compile-sketches action is unable to read dependancies from the
dependsfield. I have documented this issue in #204 .library.propertiesis included in the sketch directorydependskey usingre(limitation: only with ',' deliminator)install_libraries_from_library_manager()function to install identified libraries.ymlfile cc @sebromero