Fix spurious unit test failure on Windows machines #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although libraries-repository-engine is only used on a Linux machine, development of the project should be possible for
contributors using any operating system.
Previously, the "TestRegistryValidation/NonExistentFile" unit test failed when ran on a Windows machine:
```
Running tool: C:\Users\per\sdk\go1.24.0\bin\go.exe test -timeout 30s -run ^TestRegistryValidation$ github.com/arduino/libraries-repository-engine/internal/command/check-registry
--- FAIL: TestRegistryValidation (0.00s)
--- FAIL: TestRegistryValidation/NonExistentFile (0.00s)
e:\git\arduino\libraries-repository-engine\internal\command\check-registry\check-registry_test.go:57:
Error Trace: e:/git/arduino/libraries-repository-engine/internal/command/check-registry/check-registry_test.go:57
Error: Error message not equal:
expected: "while loading registry data file: stat testdata/nonexistent.txt: no such file or directory"
actual : "while loading registry data file: CreateFile testdata\\nonexistent.txt: The system cannot find the file specified."
Test: TestRegistryValidation/NonExistentFile
FAIL
FAIL github.com/arduino/libraries-repository-engine/internal/command/check-registry 0.227s
FAIL
```
The problem is that the Windows operating system generates a different error message than Linux and the test assertion
contained the Linux-specific message content.
The fix is to change the assertion so that it only checks for the presence of a distinctive fragment of the error
message which is universal.
per1234
added
topic: infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although libraries-repository-engine is only used on a Linux machine, development of the project should be possible for contributors using any operating system.
Previously, the "TestRegistryValidation/NonExistentFile" unit test failed when ran on a Windows machine:
The problem is that the Windows operating system generates a different error message than Linux and the test assertion contained the Linux-specific message content.
The fix is to change the assertion so that it only checks for the presence of a distinctive fragment of the error message which is universal.