Skip to content

Conversation

@0verflux
Copy link

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Sep 12, 2024
@github-actions
Copy link
Contributor

A problem was found with your submission https://github.com/0verflux/StateMachineLib

ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @0verflux
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@0verflux
Copy link
Author

@ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

A problem was found with your submission https://github.com/0verflux/StateMachineLib

ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @0verflux
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @0verflux. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.

If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:

https://github.com/0verflux/StateMachineLib/tree/v3.0.0

(note that the repository did not contain a library.properties file at the tagged point in the revision history)

❗ Remember to update the version field in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Sep 12, 2024
@0verflux
Copy link
Author

@ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label Sep 12, 2024
@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/0verflux/StateMachineLib:

Linting library in StateMachineLib
INFO: No header file found matching library name (StateMachineLib.h). Best practices are for primary header filename to 
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
ERROR: Library name StateMachineLib is in use by a library in the Library Manager index. Each library must have a unique
       name value. If your library is already in the index, use the "--library-manager update" flag.                    
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format           
       (Rule LP017)                                                                                                     
ERROR: Missing paragraph field in library.properties                                                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP034)                                                                                          
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 2 ERRORS, 1 WARNINGS

-------------------

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @0verflux
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of a tidy repository, I'm going to close this due to lack of activity.

@0verflux if you ever resolve the issue reported by the bot, please submit another pull request to add the library.

I'll continue to monitor this thread, so feel free to let me know if you have any questions or concerns.

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Sep 16, 2024
@per1234 per1234 self-assigned this Sep 16, 2024
@per1234 per1234 closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: waiting for information More information must be provided before work can proceed topic: submission Add library to the list

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants