-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
MX8650 library for Arduino and ESP #5233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A problem was found with your submission https://github.com/styropyr0/MX8650 ❌ ERROR: The repository has no tags. You need to create a release or tag that matches the |
|
Thanks for your interest in contributing to the Arduino Library Manager index @styropyr0 After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
|
Hello! I'm checking your submission again. |
|
A problem was found with your submission https://github.com/styropyr0/MX8650 ❌ ERROR: Library is missing a library.properties metadata file. See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata |
|
Thanks for your interest in contributing to the Arduino Library Manager index @styropyr0 After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
|
Hello! I'm checking your submission again. |
|
A problem was found with your submission https://github.com/styropyr0/MX8650 ❌ ERROR: Library is missing a library.properties metadata file. See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata |
|
Thanks for your interest in contributing to the Arduino Library Manager index @styropyr0 After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
|
Hello! I'm checking your submission again. |
|
Arduino Lint has suggestions for possible improvements to https://github.com/styropyr0/MX8650: |
|
Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index. The library(s) will be available for installation via Library Manager within a day's time. You can check the logs from the Library Manager indexer for your library(s) here: |
|
Hello @styropyr0. The automated system here only operates on open pull requests. Since your submission was already accepted and the pull request merged, the bot won't pay any more attention to this pull request. But this human is happy to provide assistance. Was there something you needed from the bot? |
|
Hello @per1234 , |
Are you referring to this part of the bot's comment?: If so, this is not an error. It is only telling you that your library does not follow the best practices of the primary header filename matching the sanitized library name. The library name is defined by the https://github.com/styropyr0/MX8650/blob/main/library.properties#L1 Best practices would be for the library to have a primary header file matching the library name, with spaces replaced by underscores: The reason this is considered a best practice is because in the case where multiple libraries contain a header file matching an https://arduino.github.io/arduino-cli/latest/sketch-build-process/#library-name-priority So if you like, you can add a header file to the library named #include "mx8650.h"But please note that this is not an error. It is only a suggestion the bot is making in order to encourage library authors to follow best practices. If you decide that you don't want to follow the suggestion, there are no consequences. Your library has already been accepted for inclusion in the Arduino Library Manager and it will remain in Library Manager regardless.
It is not necessary. If you want to make improvements to the library, that is completely fine. Just make a new release of the library when you are ready and it will be automatically picked up by the Library Manager system: |
This library facilitates communication with the MX8650 mouse controller, allowing for reading and writing data to its internal registers. It is essential to refer to the MX8650 datasheet before transferring data to the sensor registers.
Author: Saurav Sajeev