Skip to content

Remove "UltiBlox DisplayValueCommon" #5414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2024
Merged

Remove "UltiBlox DisplayValueCommon" #5414

merged 1 commit into from
Nov 26, 2024

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Nov 13, 2024

Companion to #5411

@per1234 per1234 added topic: removal Remove library from the list status: pending backend Depends on backend maintenance operations labels Nov 13, 2024
@per1234 per1234 added status: on hold Do not proceed at this time and removed status: pending backend Depends on backend maintenance operations labels Nov 21, 2024
per1234
per1234 commented Nov 21, 2024
View reviewed changes
Copy link
Contributor Author

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now put on hold pending the correction of a problem that was later introduced in the companion PR: #5411 (review)

@per1234 per1234 added status: pending backend Depends on backend maintenance operations and removed status: on hold Do not proceed at this time labels Nov 24, 2024
@MatteoPologruto MatteoPologruto self-assigned this Nov 26, 2024
MatteoPologruto
MatteoPologruto approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:

2024/11/26 15:16:39 Loaded 7503 libraries from DB
Removing UltiBlox DisplayValueCommon
Success!

@MatteoPologruto MatteoPologruto merged commit 8014b42 into arduino:production Nov 26, 2024
2 checks passed
@MatteoPologruto MatteoPologruto added the conclusion: resolved Issue was resolved label Nov 26, 2024
@per1234 per1234 deleted the remove-UltiBlox_DisplayValueCommon branch November 26, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatteoPologruto MatteoPologruto MatteoPologruto approved these changes

Assignees

@MatteoPologruto MatteoPologruto

Labels
conclusion: resolved Issue was resolved status: pending backend Depends on backend maintenance operations topic: removal Remove library from the list
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@per1234 @MatteoPologruto