Skip to content

Conversation

Giosephe
Copy link

This pull request adds the FuzzyMamdani library to the Arduino Library Registry.
The library is designed for beginners and students, offering an easy way to implement fuzzy logic control systems.
Repository: https://github.com/Giosephe/FuzzyMamdani

Copy link
Contributor

Hi @Giosephe.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added the topic: other Something other than a library list request label Jan 17, 2025
@github-actions github-actions bot requested a review from per1234 January 17, 2025 03:10
Copy link
Contributor

Hi @Giosephe.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

Copy link
Contributor

Hi @Giosephe.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@Giosephe
Copy link
Author

Hi @per1234, I have updated the JSON file to fix the UTF-8 encoding issue. Could you kindly review my submission? Thank you!

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Giosephe. Thanks for your interest in contributing to the Arduino Library Manager.

You are not coming even close to following the correct procedure for submitting a library. Please carefully read and follow the instructions for submitting a library that are provided in the readme of this repository:

https://github.com/arduino/library-registry#adding-a-library-to-library-manager

If you have any questions or problems while following those instructions, just comment on this pull request thread with a detailed description of the situation and I'll provide further assistance.

@per1234 per1234 added the status: changes requested Changes to PR are required before merge label Jan 17, 2025
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of a tidy repository, I'm going to close this due to lack of activity.

@Giosephe if you ever want to have another try at registering the library, please submit another pull request to add the library, making sure to carefully follow the instructions this time.

I'll continue to monitor this thread, so feel free to let me know if you have any questions or concerns.

@per1234 per1234 closed this Jan 20, 2025
@per1234 per1234 added conclusion: invalid Issue/PR not valid and removed status: changes requested Changes to PR are required before merge labels Jan 20, 2025
@per1234 per1234 self-assigned this Jan 20, 2025
@Giosephe
Copy link
Author

Thank you for your understanding and for taking the time to review my pull request. I’d like to explain that the inactivity was due to my studies, which required me to reduce my free time significantly. However, I want to assure you that I haven’t lost interest in integrating my library into the Arduino Library Registry.

I plan to revisit this project in about two weeks and will make sure to carefully review and meet all the necessary requirements for the next submission. I greatly appreciate your guidance and support throughout this process.

Thank you again for your patience and help. I’ll make sure to follow the instructions closely next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: invalid Issue/PR not valid topic: other Something other than a library list request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants