Skip to content

Conversation

a-saab
Copy link
Contributor

@a-saab a-saab commented Feb 8, 2025

This PR adds PrayerTimes, an Arduino library for calculating Islamic prayer times offline
using multiple calculation methods (MWL, ISNA, Umm al-Qura, etc.).

Copy link
Contributor

github-actions bot commented Feb 8, 2025

Hi @a-saab
A problem was found with your pull request:

ERROR: Pull request removes newline from the end of a file.
Please add a blank line to the end of the file.

Please resolve this error. The checks will automatically run again once that is done.

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot added the topic: invalid Request could not be processed label Feb 8, 2025
@github-actions github-actions bot requested a review from per1234 February 8, 2025 00:38
Copy link
Contributor

github-actions bot commented Feb 8, 2025

Hi @a-saab.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added topic: other Something other than a library list request and removed topic: invalid Request could not be processed labels Feb 8, 2025
Copy link
Contributor

github-actions bot commented Feb 8, 2025

Hi @a-saab.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot removed the request for review from per1234 February 8, 2025 00:48
@github-actions github-actions bot added topic: submission Add library to the list and removed topic: other Something other than a library list request labels Feb 8, 2025
Copy link
Contributor

github-actions bot commented Feb 8, 2025

Arduino Lint has suggestions for possible improvements to https://github.com/a-saab/PrayerTimes:

Linting library in PrayerTimes
WARNING: Invalid category field value Time in library.properties                                               
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP038)                                                                                          

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in PrayerTimes/examples/ISNA - Montreal
WARNING: Sketch file/folder name mismatch. The primary sketch file name must match the folder: ISNA - Montreal.ino
         See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#primary-sketch-file              
         (Rule SS001)                                                                                             

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linter results for projects: 0 ERRORS, 2 WARNINGS

@github-actions github-actions bot merged commit 8b4c081 into arduino:main Feb 8, 2025
11 checks passed
Copy link
Contributor

github-actions bot commented Feb 8, 2025

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/a-saab/PrayerTimes/

github-actions bot pushed a commit that referenced this pull request Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant