Skip to content

Conversation

@tabahi
Copy link
Contributor

@tabahi tabahi commented Feb 26, 2025

  • Added a new StatefulGSMLib for SIM800 modules.
  • TabahiConsole needs to be removed since its hosting service is no longer operational.

@github-actions
Copy link
Contributor

Hi @tabahi.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added the topic: modification Change existing list entry label Feb 26, 2025
@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/tabahi/StatefulGSMLib:

Linting library in StatefulGSMLib
ERROR: Library name StatefulGSMLib not found in the Library Manager index. Library names are not allowed to change after
       being added to the index.                                                                                        
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in StatefulGSMLib/examples/SMS_rx_tx

Linter results for project: no errors or warnings

-------------------

Linting sketch in StatefulGSMLib/examples/TCP_fetch_HTTP

Linter results for project: no errors or warnings

-------------------

Linting sketch in StatefulGSMLib/examples/UDP_monitoring

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @tabahi
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 February 26, 2025 13:48
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tabahi. Please use a separate pull request for each distinct operation:

  • One pull request for the removal of the "TabahiConsole" library
  • One pull request for the submission of the "StatefulGSMLib" library

The reason this is important is because we have an automated system for handling submissions, but removals must be handled manually. If you unnecessarily jam both operations into single pull request then it means the automated system can't handle your submission.

@per1234 per1234 self-assigned this Feb 26, 2025
@per1234 per1234 added status: changes requested Changes to PR are required before merge topic: submission Add library to the list topic: removal Remove library from the list and removed topic: modification Change existing list entry labels Feb 26, 2025
@tabahi tabahi closed this Feb 27, 2025
@github-actions github-actions bot added topic: other Something other than a library list request and removed status: changes requested Changes to PR are required before merge topic: submission Add library to the list topic: removal Remove library from the list labels Feb 27, 2025
@github-actions
Copy link
Contributor

Hi @tabahi.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot requested a review from per1234 February 27, 2025 05:33
@per1234 per1234 added conclusion: duplicate Has already been submitted topic: submission Add library to the list topic: removal Remove library from the list and removed topic: other Something other than a library list request labels Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conclusion: duplicate Has already been submitted topic: removal Remove library from the list topic: submission Add library to the list

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants