Skip to content

Conversation

@gigapod
Copy link
Contributor

@gigapod gigapod commented Feb 26, 2025

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Feb 26, 2025
@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/sparkfun/SparkFun_Soil_Moisture_Arduino_Library:

Linting library in SparkFun_Soil_Moisture_Arduino_Library
WARNING: Git submodule detected. Library Manager installations and installations from GitHub's "Download ZIP" will only 
         contain an empty folder in place of the submodule. (Rule LS004)                                                
WARNING: library.properties name SparkFun Soil Moisture Sensor contains spaces. Although supported, best practices is to
         not use spaces.                                                                                                
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
ERROR: Invalid format of library.properties depends field SparkFun Toolkit >=1.0.0                           
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP047)                                                                                          
WARNING: library.properties depends field item(s) SparkFun Toolkit >=1.0.0 not found in the Library Manager index.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format   
         (Rule LP048)                                                                                             

Linter results for project: 1 ERRORS, 3 WARNINGS

-------------------

Linting sketch in SparkFun_Soil_Moisture_Arduino_Library/examples/Example_01_BasicReadings

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_Soil_Moisture_Arduino_Library/examples/Example_02_ReadingsAndLED

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_Soil_Moisture_Arduino_Library/examples/Example_03_LEDFlashMoisture

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_Soil_Moisture_Arduino_Library/examples/Example_04_ChangeI2CAddress

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 3 WARNINGS

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @gigapod
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@gigapod
Copy link
Contributor Author

gigapod commented Feb 26, 2025

@ArduinoBot - this is fixed

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/sparkfun/SparkFun_Soil_Moisture_Arduino_Library:

Linting library in SparkFun_Soil_Moisture_Arduino_Library
WARNING: Git submodule detected. Library Manager installations and installations from GitHub's "Download ZIP" will only 
         contain an empty folder in place of the submodule. (Rule LS004)                                                
WARNING: library.properties name SparkFun Soil Moisture Sensor contains spaces. Although supported, best practices is to
         not use spaces.                                                                                                
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
ERROR: Invalid format of library.properties depends field SparkFun Toolkit >=1.0.0                           
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP047)                                                                                          
WARNING: library.properties depends field item(s) SparkFun Toolkit >=1.0.0 not found in the Library Manager index.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format   
         (Rule LP048)                                                                                             

Linter results for project: 1 ERRORS, 3 WARNINGS

-------------------

Linting sketch in SparkFun_Soil_Moisture_Arduino_Library/examples/Example_01_BasicReadings

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_Soil_Moisture_Arduino_Library/examples/Example_02_ReadingsAndLED

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_Soil_Moisture_Arduino_Library/examples/Example_03_LEDFlashMoisture

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_Soil_Moisture_Arduino_Library/examples/Example_04_ChangeI2CAddress

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 3 WARNINGS

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @gigapod
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@gigapod
Copy link
Contributor Author

gigapod commented Feb 26, 2025

ahh rel needed updating - @ArduinoBot - this is fixed

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/sparkfun/SparkFun_Soil_Moisture_Arduino_Library:

Linting library in SparkFun_Soil_Moisture_Arduino_Library
WARNING: Git submodule detected. Library Manager installations and installations from GitHub's "Download ZIP" will only 
         contain an empty folder in place of the submodule. (Rule LS004)                                                
WARNING: library.properties name SparkFun Soil Moisture Sensor contains spaces. Although supported, best practices is to
         not use spaces.                                                                                                
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
ERROR: Invalid format of library.properties depends field SparkFun Toolkit >=1.0.0                           
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP047)                                                                                          
WARNING: library.properties depends field item(s) SparkFun Toolkit >=1.0.0 not found in the Library Manager index.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format   
         (Rule LP048)                                                                                             

Linter results for project: 1 ERRORS, 3 WARNINGS

-------------------

Linting sketch in SparkFun_Soil_Moisture_Arduino_Library/examples/Example_01_BasicReadings

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_Soil_Moisture_Arduino_Library/examples/Example_02_ReadingsAndLED

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_Soil_Moisture_Arduino_Library/examples/Example_03_LEDFlashMoisture

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_Soil_Moisture_Arduino_Library/examples/Example_04_ChangeI2CAddress

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 3 WARNINGS

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @gigapod
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@gigapod
Copy link
Contributor Author

gigapod commented Feb 26, 2025

@ArduinoBot - this is fixed

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/sparkfun/SparkFun_Soil_Moisture_Arduino_Library:

Linting library in SparkFun_Soil_Moisture_Arduino_Library
WARNING: Git submodule detected. Library Manager installations and installations from GitHub's "Download ZIP" will only 
         contain an empty folder in place of the submodule. (Rule LS004)                                                
WARNING: library.properties name SparkFun Soil Moisture Sensor contains spaces. Although supported, best practices is to
         not use spaces.                                                                                                
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

Linting sketch in SparkFun_Soil_Moisture_Arduino_Library/examples/Example_01_BasicReadings

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_Soil_Moisture_Arduino_Library/examples/Example_02_ReadingsAndLED

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_Soil_Moisture_Arduino_Library/examples/Example_03_LEDFlashMoisture

Linter results for project: no errors or warnings

-------------------

Linting sketch in SparkFun_Soil_Moisture_Arduino_Library/examples/Example_04_ChangeI2CAddress

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 2 WARNINGS

@github-actions github-actions bot merged commit c6a2edc into arduino:main Feb 26, 2025
14 checks passed
@github-actions
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/sparkfun/SparkFun_Soil_Moisture_Arduino_Library/

github-actions bot pushed a commit that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: submission Add library to the list

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant