Skip to content

Conversation

@cmaglie
Copy link
Member

@cmaglie cmaglie commented Nov 6, 2025

Previously, the zip archives were created without a root folder. This PR fixes this issue.
This is actually a regression after #81 , which removed the DistTask section:

-mkdir -p {{.PLATFORM_DIR}}
-cp ../LICENSE.txt {{.PLATFORM_DIR}}
 docker run ...

You must run the mkdir command before starting Docker to ensure write permission on the PLATFORM_DIR directory; otherwise, the directory will be created by the go build command inside the Docker container, which runs as root, making it impossible to copy the LICENSE file later.

We might want to push this change upstream in the assets repo. /cc @per1234

@cmaglie cmaglie self-assigned this Nov 6, 2025
@cmaglie cmaglie added topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project labels Nov 6, 2025
@cmaglie cmaglie requested a review from a team November 6, 2025 10:06
@cmaglie cmaglie merged commit df76715 into main Nov 6, 2025
50 checks passed
@cmaglie cmaglie deleted the fix-archive-format branch November 6, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants