Extra case added when checking the energy threshold#18
Open
huw-dls wants to merge 1 commit intoareaDetector:masterfrom
Open
Extra case added when checking the energy threshold#18huw-dls wants to merge 1 commit intoareaDetector:masterfrom
huw-dls wants to merge 1 commit intoareaDetector:masterfrom
Conversation
… a Lambda-Flex, a very small number for the energy threshold was consistently seen, around 1e-300keV. The comparison between the new and previous thresholds would then not allow 0keV to be set. This very small unset detector threshold led to long acquisitions only containing the odd single count in any pixel, possibly similar in behaviour to the threshold being very high (>40keV).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In testing the Lambda-Flex at Diamond, we found that if the energy threshold was not set, we would only ever see single counts in any pixel and often not even one count for a 10s acquisition. (Limited debugging showed that the provided xsp threshold() function always seems to return the first threshold as 1.7e-313.)
This pull request allows a very small "unset" threshold to be changed to 0keV. At least in our case (with our Lambda-Flex) this avoids acquisitions appearing not to work from EPICS when the user thinks they have set a 0keV threshold on startup.