Fix broken CI deploy and GitHub Pages workflows#53
Merged
Conversation
- deploy-kind.yaml: Remove push/PR triggers, keep only manual workflow_dispatch. The job requires a self-hosted runner with Docker which is not currently registered, causing jobs to queue forever. - publish-pages.yaml: Bump configure-pages v3->v5, upload-pages-artifact v2->v3, deploy-pages v2->v4. The old v2 actions depend on deprecated upload-artifact v3 which GitHub now blocks. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy-kind.yaml: Remove
push/pull_requesttriggers, keep onlyworkflow_dispatch(manual). The job requires a self-hosted runner with thedockerlabel, but no runners are registered — jobs queue forever and never execute.publish-pages.yaml: Bump deprecated GitHub Actions:
actions/configure-pagesv3 -> v5actions/upload-pages-artifactv2 -> v3actions/deploy-pagesv2 -> v4The old
upload-pages-artifact@v2depends onupload-artifact@v3, which GitHub now blocks with: "This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v3"Required GitHub Settings Changes
After merging, the following manual settings changes are needed in the repo:
Settings > Pages > Build and deployment: Change Source from "Deploy from a branch" to "GitHub Actions". The current setting is
legacy(deploy from/docsonmain), but the workflow uses the Actions-based deploy flow.Settings > Actions > Runners (when ready): Register a self-hosted Linux runner with Docker installed and labels
self-hosted,dockerto re-enable the Kind deploy workflow.Test plan
publish-pages.yamlsucceeds after merge (GitHub Pages deploys)deploy-kind.yamlno longer triggers on push/PRMade with Cursor