Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements additional query methods to extract various logging data (instance names, IDs, thread names, priorities, etc.) and fixes a bug related to the application bitness. Key changes include new inline methods in LoggerClient and LogObserverBase, significant refactoring of SQLite statement binding and retrieval functions to use 0‑based indexing, and major modifications in LogSqliteDatabase for improved database connection management and logging operations.
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| framework/areglogger/client/private/LoggerClient.hpp | Added inline query methods for retrieving logging data. |
| framework/areglogger/client/private/LogObserverBase.cpp | Implemented wrapper functions calling LoggerClient query methods. |
| framework/areglogger/client/LogObserverBase.hpp | Declared new query methods for logging data extraction. |
| framework/aregextend/db/private/SqliteStatement.cpp and .hpp | Refactored binding and column access methods to follow 0‑based indexing with updated docs. |
| framework/aregextend/db/private/SqliteDatabase.cpp | Adjusted initialization logic and fixed typo in commit rollback SQL string. |
| framework/aregextend/db/private/LogSqliteDatabase.cpp | Major refactoring to use the database object and prepared statements for logging. |
| framework/aregextend/db/LogSqliteDatabase.hpp | Updated API and method declarations to support the new logging queries. |
| framework/areg/logging/IELogDatabaseEngine.hpp | Updated method name to reflect the new API (areTablesInitialized). |
| framework/areg/base/GETypes.h | Updated id_type typedef and corresponding comments to better reflect platform distinctions. |
Comments suppressed due to low confidence (3)
framework/aregextend/db/SqliteStatement.hpp:125
- Ensure that all function comments in SqliteStatement.hpp consistently reflect the new 0-based indexing for parameter binding and column retrieval methods to avoid any confusion.
* \param index The 0-based parameter index.
framework/aregextend/db/private/SqliteDatabase.cpp:52
- [nitpick] Clarify why mDbPath is default-initialized in the initializer list and then assigned in the constructor body; a brief comment explaining the rationale would improve maintainability.
, mDbPath ( )
framework/areg/base/GETypes.h:65
- [nitpick] Update the comment for id_type in the BIT32 branch to accurately reflect that the type is 32-bit when BIT32 is defined, to avoid potential confusion.
typedef uint64_t id_type;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented extra methods to query logging data.
fixed bug of application bitnes