Changed Configuration Window size so text doesn't get cut off, and added memory editor ability to swich between binary, oct, and hex view#2035
Open
ScraperMan2002 wants to merge 24 commits intoares-emulator:masterfrom
Conversation
Changed the way validateMenuItem checks for menu items, now they check based on functioanlity "copy", "selectAll".
CMDA This is my personal fork, and I approve of this merge request.
…ARNING: I have no idea how all this works. This could be buggy. I highly recommend the person who approves of this push to please take a look at it and fix any bugs. Because I have no clue why this worked, and I don't have any more patience with fixing whatever will be thrown in the future.
-Removed extra [item setTarget:NSApp];
…ext for options don't get cut off.
… Hexadecimal, Octal, and Binary
ScraperMan2002
changed the title
Contributor
Author
|
I also added memory editor ability to swich between binary, oct, and hex view. This is only available currently on MacOS version, so I don't know what else to do. I need someone to help me with the other GUI versions. |
…cimal in QT and GTK, fixed Windows implementation bug.
… being able to overload unsigned char (u16).
…row" and be done with it.
1. A single click and you can edit the contents of the cell/memory at an address 2. You can edit an address in either hexadecimal, binary, or octal depending on the Radio Button. 3. The base can be represented with u8 integer. So I changed that for every hex-edit no matter the platform.
…ngle-click Major Edits to hex-edit on MacOS:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally, as per this image on MacOS, important text detailing the function of an option gets cut off, and you aren't allowed to resize the Configuration window. So the size of the window was changed so such text doesn't get cut off anymore.