n64: implement eeprom write timing and status flags#2442
Open
rasky wants to merge 1 commit intoares-emulator:masterfrom
Open
n64: implement eeprom write timing and status flags#2442rasky wants to merge 1 commit intoares-emulator:masterfrom
rasky wants to merge 1 commit intoares-emulator:masterfrom
Conversation
Contributor
|
Do the new values in cartridge.hpp need to be serialized out as part of save states? |
Collaborator
Author
|
right fixed thanks |
Contributor
|
Also need to bump the serializer version in n64/system/serialization.cpp |
Currently Ares implements an infinitely fast EEPROM, but alas real EEPROMs can take even 20 ms to save a single block of 8 bytes. This commit implement approximate timings and the related flag to notify the CPU that the EEPROM is busy writing data.
Collaborator
Author
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently Ares implements an infinitely fast EEPROM, but alas real EEPROMs can take even 20 ms to save a single block of 8 bytes.
This commit implement approximate timings and the related flag to notify the CPU that the EEPROM is busy writing data.