Enable residual calculation during irradiation and evaluation#48
Open
LukeSeifert wants to merge 102 commits intoarfc:mainfrom
Open
Enable residual calculation during irradiation and evaluation#48LukeSeifert wants to merge 102 commits intoarfc:mainfrom
LukeSeifert wants to merge 102 commits intoarfc:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR enables users to include calculation of the residual during irradiation, which differs from existing methodologies which only allow for calculation of residuals post-irradiation.
This PR also includes a point reactor kinetics solver in the
phd_resultsexample, such that comparisons can be made between results calculated using different methodologies to evaluate their impact on simplified reactor transients.Also in this PR is a small change to the code such that a minimum timestep can be set for OpenMC. This allows the user to use a smaller timestep while maintaining the same in-core and ex-core residence times.
Finally, this PR also includes the
debug DNPfunctionality, such that users may manually define a DNP for testing purposes.Many of the line changes are due to changes in the integration test files. These changed because I have added the count rate at time 0 for easier debugging and to mitigate bugs in time offsets.
The main components I would like reviewed closely are the actual MoSDeN code changes (changes to the examples and tests are less critical; most of the test changes just cover testing the new functionality and adjustments based on restructured output files)
Types of changes
Associated Issues and PRs
PRs:
#46 must be merged before this PR
Issues:
Associated Developers
Checklist for Reviewers
Reviewers should use this link to get to the
Review Checklist before they begin their review.