Conversation
…tes-obsidian into multilanguage
| import t from "../lang/helper"; | ||
|
|
||
|
|
||
| interface IDateCompletion { |
There was a problem hiding this comment.
Since this only had a label: string I removed it, that made the code a bit more readable (the interface contained only a string, now it's just a string), but if it was necessary then I can of course revert it
| } | ||
|
|
||
| private getTimeSuggestions(inputStr: string, lang: string): string[] { | ||
| if (inputStr.match(new RegExp(`^${t("time", lang)}`))) { |
There was a problem hiding this comment.
This is the way that I dealt with the suggestions: the regex contains translatable parts. So time for English, tijd voor Dutch, etc. Then everything about translations (both the actual suggestions, and the regex for determining them) was done the same way
| "es5", | ||
| "scripthost", | ||
| "es2015" | ||
| "es2019" |
There was a problem hiding this comment.
Necessary for Array.flatMap. Not sure if this breaks anything, if it does I can revert it since a flatMap can easily be transformed into es2015 compatible code
|
Sorry about that! GitHub freaked out when I deleted my branch earlier today! It should be good now! |
|
OK no problem, I merged
How did you get this working for you? The only relevant thing changed is |
|
Sorry, we switched to yarn on this release! I'll add to the changelog now |
…into multilanguage
|
@argenos I merged master back into this branch and set it as ready for review, are you willing to review it? |
…into multilanguage
Just did yarn install
|
What is the current status of this? |
4 participants
Implements #19