[REFACTOR][ENHANCEMENT] argilla server: better OAuth2 integration#5689
Merged
frascuchon merged 38 commits intodevelopfrom Jan 29, 2025
Merged
[REFACTOR][ENHANCEMENT] argilla server: better OAuth2 integration#5689frascuchon merged 38 commits intodevelopfrom
argilla server: better OAuth2 integration#5689frascuchon merged 38 commits intodevelopfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5689 +/- ##
===========================================
- Coverage 91.93% 91.55% -0.38%
===========================================
Files 161 159 -2
Lines 6927 6987 +60
===========================================
+ Hits 6368 6397 +29
- Misses 559 590 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
frascuchon
commented
Nov 14, 2024
…ithub.com:argilla-io/argilla into refactor/argilla-server/better-oauth2-integration
Closed
frascuchon
changed the title
argilla server: better oauth2 integrationargilla server: better OAuth2 integration
# Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> This PR adds logic to the sign-in page to include a default OAuth provider button. So, users can sign using whatever provider is defined. Refs #5689 **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Improvement (change adding some improvement to an existing functionality) - Documentation update **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: Leire Aguirre <leire@argilla.io>
|
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-5689-ki24f765kq-no.a.run.app |
# Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Docs for changes included in #5689 **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Documentation update **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
jfcalvo
approved these changes
Dec 3, 2024
for more information, see https://pre-commit.ci
# Add keycloak SSO Based on discussion in #5691 Points that need some feedback: - A lot of configurations are set via env variables now. Not sure if that's ideal, error messages if something is not set correctly can be rather cryptic with social auth lib - I added the Keycloak logo to the Oauth button id the provider is keycloak, generally the same could also be done for the HF logo not having a separate button - Is the documentation to set-up a keycloak server sufficient? **Type of change** - Improvement (change adding some improvement to an existing functionality) - Documentation update **How Has This Been Tested** Local build & Keycloak installation as described in the documentation. **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - TODO I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: Paco Aranda <frascuchon@gmail.com> Co-authored-by: Francisco Aranda <francis@argilla.io> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Paco Aranda <francisco.aranda@huggingface.co>
frascuchon
deleted the
refactor/argilla-server/better-oauth2-integration
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the
social_coreintegration, making setup backends simpler.Improvements:
SOCIAL_AUTH_*environment variablesenabledextra_backends* (some backends may be not fully supported, but users can create issues for that)Type of change
How Has This Been Tested
Checklist