Fix: Update and repair broken badges in READMEs#625
Open
sazuyakun wants to merge 6 commits intoargmin-rs:mainfrom
Open
Fix: Update and repair broken badges in READMEs#625sazuyakun wants to merge 6 commits intoargmin-rs:mainfrom
sazuyakun wants to merge 6 commits intoargmin-rs:mainfrom
Conversation
Updated GitHub Actions badge link and label in README.
Removed duplicate GitHub Actions badge from README.
stefan-k
requested changes
Sep 28, 2025
Member
stefan-k
left a comment
stefan-k
left a comment
There was a problem hiding this comment.
Excellent, thank you! :) I only have two questions (which are actually the same)
| src="https://img.shields.io/github/actions/workflow/status/argmin-rs/argmin/python.yml?branch=main&label=argmin CI&style=flat-square" | ||
| <a href="https://github.com/argmin-rs/argmin/actions/workflows/ci.yml"> | ||
| <img | ||
| src="https://img.shields.io/github/actions/workflow/status/argmin-rs/argmin/ci.yml?branch=main&label=CI&style=flat-square" |
Member
There was a problem hiding this comment.
I believe this should remain python.yml, or am I wrong?
| src="https://img.shields.io/github/actions/workflow/status/argmin-rs/argmin/python.yml?branch=main&label=argmin CI&style=flat-square" | ||
| <a href="https://github.com/argmin-rs/argmin/actions/workflows/ci.yml"> | ||
| <img | ||
| src="https://img.shields.io/github/actions/workflow/status/argmin-rs/argmin/ci.yml?branch=main&label=CI&style=flat-square" |
Member
There was a problem hiding this comment.
I believe this should remain python.yml, or am I wrong?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #625 +/- ##
==========================================
- Coverage 91.73% 91.72% -0.01%
==========================================
Files 177 177
Lines 20840 20840
==========================================
- Hits 19117 19116 -1
- Misses 1723 1724 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
My bad, I might have forgotten to cross-check it. For the argmin-testfunctions-py/README.md, it will be python.yml |
stefan-k
reviewed
Sep 28, 2025
Comment on lines
-61
to
72
|
|
||
| [](https://bootstrap-slack.herokuapp.com/) | ||
| [](https://github.com/twbs/bootstrap/actions?query=workflow%3AJS+Tests+branch%3Amain) | ||
| [](https://www.npmjs.com/package/bootstrap) | ||
| [](https://rubygems.org/gems/bootstrap) | ||
| [](https://atmospherejs.com/twbs/bootstrap) | ||
| [](https://packagist.org/packages/twbs/bootstrap) | ||
| [](https://www.nuget.org/packages/bootstrap/absoluteLatest) | ||
| [](https://david-dm.org/twbs/bootstrap?type=peer) | ||
| [](https://david-dm.org/twbs/bootstrap?type=dev) | ||
| [](https://coveralls.io/github/twbs/bootstrap?branch=main) | ||
| [](https://github.com/twbs/bootstrap/blob/main/dist/css/bootstrap.min.css) | ||
| [](https://github.com/twbs/bootstrap/blob/main/dist/css/bootstrap.min.css) | ||
| [](https://github.com/twbs/bootstrap/blob/main/dist/js/bootstrap.min.js) | ||
| [](https://github.com/twbs/bootstrap/blob/main/dist/js/bootstrap.min.js) | ||
| [](https://www.browserstack.com/automate/public-build/SkxZcStBeExEdVJqQ2hWYnlWckpkNmNEY213SFp6WHFETWk2bGFuY3pCbz0tLXhqbHJsVlZhQnRBdEpod3NLSDMzaHc9PQ==--3d0b75245708616eb93113221beece33e680b229) | ||
| [](#backers) |
Member
There was a problem hiding this comment.
This entire file can be left as it was originally, since it is related to the website template and not argmin itself.
Author
There was a problem hiding this comment.
Should i make the changes, to bring back the original links?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #623
Description
This PR addresses issue #623 by updating and fixing the badges across all relevant README files in the project. The goal is to ensure all badges are rendering correctly and linking to the correct, up-to-date resources. Additionally, some of the outdated links that weren't working are also removed.
Changes Made