Change default time to None in IterState#641
Open
GermanHeim wants to merge 2 commits intoargmin-rs:mainfrom
Open
Change default time to None in IterState#641GermanHeim wants to merge 2 commits intoargmin-rs:mainfrom
GermanHeim wants to merge 2 commits intoargmin-rs:mainfrom
Conversation
Updated the IterState struct to initialize the time field as None instead of Some(Duration::ZERO). Adjusted related documentation and assertions to fix tests.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #641 +/- ##
==========================================
+ Coverage 91.72% 91.74% +0.01%
==========================================
Files 177 177
Lines 20840 20840
==========================================
+ Hits 19116 19119 +3
+ Misses 1724 1721 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Lovely, thanks! |
Contributor
Author
|
From what I can see, the only observer that actually uses time is the observer spectator (in observe_iter and handle_connection). Currently, it works because it uses One option would be to change the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Updated the
IterStatestruct to initialize the time field asNoneinstead ofSome(Duration::ZERO). This should fix the timer showing as 0 ns, which was introduced in commit 6492020.🔨 Changes Made
IterStatestruct to initialize the time field asNoneinstead ofSome(Duration::ZERO).🔗 Related Issues
Closes #640