remove self.logger from reader factory#313
Open
karimyoussef91 wants to merge 1 commit intoargonne-lcf:mainfrom
Open
remove self.logger from reader factory#313karimyoussef91 wants to merge 1 commit intoargonne-lcf:mainfrom
karimyoussef91 wants to merge 1 commit intoargonne-lcf:mainfrom
Conversation
Collaborator
|
@karimyoussef91 the CI fail is coming due to another bug which is already fixed. can u rebase on main and push |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since reader_factory's get_reader was changed to be a static method, the self.logger at line 39 needed to be removed as it throws error "self not defined" when using a custom data reader.