Open
Conversation
Member
Author
|
@0xE0F Could you fix the conflicts? |
Signed-off-by: Denis Barakhtanov <dbarahtanov@enakta.com>
DAOS provides ready to use DaosDataset that can be directly pluggted in into torch.DataLoader. DLIO TorchDataLoader uses it with support of the custom Dataset that delegates sample reading to the FormatReader. For DAOS we can ommit FormatReader and create a wrapper for DaosDataset that interact with performance tooling and pass it directly to the torch.DataLoader.
0xE0F
force-pushed
the
pytorch-daos-dataloader
branch
from
25359dc to
e83d68b
Compare
Contributor
|
@zhenghh04 rebased to the latest main brach, should be good now. |
hariharan-devarajan
requested changes
Mar 22, 2026
Collaborator
hariharan-devarajan
left a comment
hariharan-devarajan
left a comment
There was a problem hiding this comment.
We are missing test cases. I understand we don't have actual doas but we should explore mocking strategies.
Contributor
I think mocking in this case would be mostly testing the mock itself as DaosDataset pretty much hands off samples loading to pytroch.DataLoader. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.