CalVer as an additional update strategy#1019
Open
r4vi wants to merge 6 commits intoargoproj-labs:master-annotation-basedfrom
Open
CalVer as an additional update strategy#1019r4vi wants to merge 6 commits intoargoproj-labs:master-annotation-basedfrom
r4vi wants to merge 6 commits intoargoproj-labs:master-annotation-basedfrom
Conversation
r4vi
requested review from
chengfang,
ishitasequeira,
jannfis and
pasha-codefresh
as code owners
--- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/argoproj-labs/argocd-image-updater?shareId=XXXX-XXXX-XXXX-XXXX). Signed-off-by: Ravi Kotecha <ravi.kotecha@novata.com>
Signed-off-by: Ravi Kotecha <ravi.kotecha@novata.com>
Signed-off-by: Ravi Kotecha <ravi.kotecha@novata.com>
Signed-off-by: Ravi Kotecha <ravi.kotecha@novata.com>
Signed-off-by: Ravi Kotecha <ravi.kotecha@novata.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1019 +/- ##
=======================================
Coverage 63.26% 63.26%
=======================================
Files 15 15
Lines 2243 2243
=======================================
Hits 1419 1419
Misses 733 733
Partials 91 91 ☔ View full report in Codecov by Sentry. |
make clear that format must be supplied Signed-off-by: Ravi Kotecha <ravi.kotecha@novata.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new update strategy called
calverfor handling calendar versioning in the Argo CD Image Updater. The changes span across multiple files to integrate this new strategy, including documentation updates, code additions, and new tests.Happy to take feedback - this is my first contribution here. The most controversial part of this PR is using
allow-tagsto provide a calver format as calver isn't really that standardised. It does feel slightly odd to me but the alternative was to introduce another annotation.