feat: fix force-update for zero-replica deployments by reading image tags from spec#1172
feat: fix force-update for zero-replica deployments by reading image tags from spec#1172chansuke wants to merge 15 commits intoargoproj-labs:master-annotation-basedfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master-annotation-based #1172 +/- ##
===========================================================
- Coverage 72.34% 71.86% -0.49%
===========================================================
Files 45 45
Lines 4278 4372 +94
===========================================================
+ Hits 3095 3142 +47
- Misses 1015 1057 +42
- Partials 168 173 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e71b77b to
6e731a7
Compare
6e731a7 to
4ea8ebe
Compare
983234f to
4d7ded9
Compare
…tags from spec Signed-off-by: chansuke <moonset20@gmail.com>
Signed-off-by: chansuke <moonset20@gmail.com>
Signed-off-by: chansuke <moonset20@gmail.com>
…deployments Signed-off-by: chansuke <moonset20@gmail.com>
Signed-off-by: chansuke <moonset20@gmail.com>
Signed-off-by: chansuke <moonset20@gmail.com>
2ea7b26 to
86bd50d
Compare
|
@chansuke can you investigate the CI failures? |
|
@chengfang |
Signed-off-by: chansuke <moonset20@gmail.com>
Signed-off-by: chansuke <moonset20@gmail.com>
|
Is there any blocker for this PR? Would be really nice to get this merged. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closes #829
Resolves continuous update attempts for deployments with 0 replicas when
force-update=trueis set