feat: fix force-update for zero-replica deployments by reading image tags from spec #1172
+237
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1172 +/- ##
==========================================
- Coverage 63.52% 63.04% -0.49%
==========================================
Files 23 23
Lines 3191 3301 +110
==========================================
+ Hits 2027 2081 +54
- Misses 1054 1106 +52
- Partials 110 114 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chansuke
requested review from
jannfis,
chengfang,
pasha-codefresh and
ishitasequeira
as code owners
chengfang
force-pushed
the
feat/update-behavior
branch
from
e71b77b to
6e731a7
Compare
chengfang
reviewed
Jul 23, 2025
chansuke
force-pushed
the
feat/update-behavior
branch
from
6e731a7 to
4ea8ebe
Compare
chengfang
force-pushed
the
feat/update-behavior
branch
2 times, most recently
from
983234f to
4d7ded9
Compare
chengfang
reviewed
Aug 11, 2025
…tags from spec Signed-off-by: chansuke <[email protected]>
Signed-off-by: chansuke <[email protected]>
Signed-off-by: chansuke <[email protected]>
…deployments Signed-off-by: chansuke <[email protected]>
Signed-off-by: chansuke <[email protected]>
Signed-off-by: chansuke <[email protected]>
chansuke
force-pushed
the
feat/update-behavior
branch
from
2ea7b26 to
86bd50d
Compare
|
@chansuke can you investigate the CI failures? |
|
@chengfang |
Signed-off-by: chansuke <[email protected]>
Signed-off-by: chansuke <[email protected]>
Signed-off-by: chansuke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #829
Resolves continuous update attempts for deployments with 0 replicas when
force-update=trueis set