-
Notifications
You must be signed in to change notification settings - Fork 316
feat: fix force-update for zero-replica deployments by reading image tags from spec #1172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master-annotation-based
Are you sure you want to change the base?
feat: fix force-update for zero-replica deployments by reading image tags from spec #1172
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master-annotation-based #1172 +/- ##
===========================================================
- Coverage 72.23% 71.74% -0.50%
===========================================================
Files 45 45
Lines 4264 4349 +85
===========================================================
+ Hits 3080 3120 +40
- Misses 1015 1056 +41
- Partials 169 173 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e71b77b to
6e731a7
Compare
6e731a7 to
4ea8ebe
Compare
983234f to
4d7ded9
Compare
…tags from spec Signed-off-by: chansuke <[email protected]>
Signed-off-by: chansuke <[email protected]>
Signed-off-by: chansuke <[email protected]>
…deployments Signed-off-by: chansuke <[email protected]>
Signed-off-by: chansuke <[email protected]>
Signed-off-by: chansuke <[email protected]>
2ea7b26 to
86bd50d
Compare
|
@chansuke can you investigate the CI failures? |
|
@chengfang |
Signed-off-by: chansuke <[email protected]>
Signed-off-by: chansuke <[email protected]>
Signed-off-by: chansuke <[email protected]>
|
Is there any blocker for this PR? Would be really nice to get this merged. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closes #829
Resolves continuous update attempts for deployments with 0 replicas when
force-update=trueis set