Skip to content

Conversation

@chansuke
Copy link
Contributor

Closes #829

Resolves continuous update attempts for deployments with 0 replicas when force-update=true is set

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.74%. Comparing base (0e94c76) to head (e01bc8f).

Files with missing lines Patch % Lines
pkg/argocd/argocd.go 57.74% 27 Missing and 3 partials ⚠️
pkg/argocd/update.go 21.05% 14 Missing and 1 partial ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           master-annotation-based    #1172      +/-   ##
===========================================================
- Coverage                    72.23%   71.74%   -0.50%     
===========================================================
  Files                           45       45              
  Lines                         4264     4349      +85     
===========================================================
+ Hits                          3080     3120      +40     
- Misses                        1015     1056      +41     
- Partials                       169      173       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chansuke chansuke marked this pull request as ready for review June 22, 2025 12:26
@chengfang chengfang force-pushed the feat/update-behavior branch from e71b77b to 6e731a7 Compare July 23, 2025 02:42
@chansuke chansuke force-pushed the feat/update-behavior branch from 6e731a7 to 4ea8ebe Compare August 3, 2025 10:37
@chengfang chengfang force-pushed the feat/update-behavior branch 2 times, most recently from 983234f to 4d7ded9 Compare August 6, 2025 18:37
@chansuke chansuke requested a review from chengfang August 9, 2025 10:38
@chansuke chansuke force-pushed the feat/update-behavior branch from 2ea7b26 to 86bd50d Compare August 11, 2025 13:47
@chengfang
Copy link
Collaborator

@chansuke can you investigate the CI failures?

@chansuke
Copy link
Contributor Author

@chengfang
yes:+1:

@chansuke chansuke requested a review from chengfang August 13, 2025 17:44
@chansuke chansuke requested a review from dkarpele as a code owner October 12, 2025 05:34
@nissessenap
Copy link

Is there any blocker for this PR? Would be really nice to get this merged.
Does it need any rethinking due to version 1.0?
Would also be nice to backport if possible, I think many of us are dragging our feet to bump to 1.0 due to a lot of changes.

@coderabbitai
Copy link

coderabbitai bot commented Nov 28, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update attempts when image is already up to date when no container exist

4 participants