-
Notifications
You must be signed in to change notification settings - Fork 316
chore(doc): note current CRD-based version status #1373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: dkarpele <[email protected]>
WalkthroughDocumentation index updated with a warning note clarifying that annotation-based configuration was removed in v1.0.0. The note directs users to use CRD-based configuration for v1.x and references legacy v0.x documentation for older versions. Changes
Pre-merge checks✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1373 +/- ##
=======================================
Coverage 70.80% 70.80%
=======================================
Files 49 49
Lines 4528 4528
=======================================
Hits 3206 3206
Misses 1125 1125
Partials 197 197 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/index.md (1)
7-12: Consider adding explicit link or pointer for accessing v0.x documentation.The note directs users to "consult the documentation for the respective version" but doesn't specify how to access v0.x docs (e.g., specific branch, git tag, separate documentation site). Adding an explicit pointer (e.g., a link to the v0.17.0 tag, a separate versioned docs site, or a git command) would improve discoverability for users migrating from older versions.
Suggested improvement:
Consider enhancing the note with a direct link or clearer instructions. For example:
~ annotation-based configuration for versions v0.x (e.g. `0.17.0`), please - consult the documentation for the respective version. + annotation-based configuration for versions v0.x (e.g. `0.17.0`), please + refer to the + [v0.17.0 release documentation](https://github.com/argoproj-labs/argocd-image-updater/tree/v0.17.0/docs) + or check out the appropriate git tag.Alternatively, if versioned docs are hosted separately (e.g., ReadTheDocs), link to the legacy version selector there instead.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/index.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Ensure registry-scanner Go modules synchronicity and run tests
- GitHub Check: Ensure code is correctly linted
- GitHub Check: Ensure unit tests are passing
- GitHub Check: Analyze (go)
- GitHub Check: build_image
🔇 Additional comments (1)
docs/index.md (1)
7-12: Excellent: Clear, prominent warning about annotation-based deprecation.The warning note directly addresses issue #1371 by explicitly stating that annotation-based configuration was removed in v1.0.0 and clarifying that v1.x uses CRD-based configuration. Placement at the top of the index ensures high visibility for users encountering the documentation.
Closes: #1371
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.