Skip to content

fix: add platform-specific functions for process management syscall#1542

Merged
chengfang merged 1 commit intoargoproj-labs:master-annotation-basedfrom
chengfang:annotation.platform.specific.syscall
Mar 16, 2026
Merged

fix: add platform-specific functions for process management syscall#1542
chengfang merged 1 commit intoargoproj-labs:master-annotation-basedfrom
chengfang:annotation.platform.specific.syscall

Conversation

@chengfang
Copy link
Collaborator

@chengfang chengfang commented Mar 16, 2026

Fixes #1512
in master-annotation-based branch, cherry-pick from #1541

Signed-off-by: Cheng Fang <cfang@redhat.com>
Co-authored-by: Claude <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9ef60994-eabd-4ae1-9094-30833922b895

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use your project's `golangci-lint` configuration to improve the quality of Go code reviews.

Add a configuration file to your project to customize how CodeRabbit runs golangci-lint.

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.34%. Comparing base (0d348ba) to head (dd1929b).
⚠️ Report is 9 commits behind head on master-annotation-based.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           master-annotation-based    #1542   +/-   ##
========================================================
  Coverage                    72.34%   72.34%           
========================================================
  Files                           45       45           
  Lines                         4278     4278           
========================================================
  Hits                          3095     3095           
  Misses                        1015     1015           
  Partials                       168      168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chengfang chengfang merged commit f3a6ce3 into argoproj-labs:master-annotation-based Mar 16, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants