test: appset image fields not respected#1611
Open
anandrkskd wants to merge 2 commits intoargoproj-labs:masterfrom
Open
test: appset image fields not respected#1611anandrkskd wants to merge 2 commits intoargoproj-labs:masterfrom
anandrkskd wants to merge 2 commits intoargoproj-labs:masterfrom
Conversation
Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com>
Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com>
svghadi
requested changes
Nov 28, 2024
| name: example-argocd | ||
| labels: | ||
| example: basic | ||
| spec: |
Collaborator
There was a problem hiding this comment.
Can you add a comment with what is expected here? Which image value will have high priority.
Comment on lines
+1
to
+6
| apiVersion: argoproj.io/v1alpha1 | ||
| kind: ArgoCD | ||
| metadata: | ||
| name: example-argocd | ||
| labels: | ||
| example: basic |
Collaborator
There was a problem hiding this comment.
Suggested change
| apiVersion: argoproj.io/v1alpha1 | |
| kind: ArgoCD | |
| metadata: | |
| name: example-argocd | |
| labels: | |
| example: basic | |
| apiVersion: argoproj.io/v1beta1 | |
| kind: ArgoCD | |
| metadata: | |
| name: example-argocd |
Lets remove the label and use v1beta api.
Comment on lines
+1
to
+8
| apiVersion: argoproj.io/v1alpha1 | ||
| kind: ArgoCD | ||
| metadata: | ||
| name: example-argocd | ||
| labels: | ||
| example: basic | ||
| spec: | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
| apiVersion: argoproj.io/v1alpha1 | |
| kind: ArgoCD | |
| metadata: | |
| name: example-argocd | |
| labels: | |
| example: basic | |
| spec: | |
| apiVersion: argoproj.io/v1beta1 | |
| kind: ArgoCD | |
| metadata: | |
| name: example-argocd | |
| spec: |
Same as previous.
svghadi
changed the title
Collaborator
|
@anandrkskd, still interested to contribute this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind chore
What does this PR do / why we need it:
This PR adds. Tests for bug appset image field not respected