feat: refactor request-scoped reconciler variables to new struct#2031
Draft
jgwest wants to merge 4 commits intoargoproj-labs:masterfrom
Draft
feat: refactor request-scoped reconciler variables to new struct#2031jgwest wants to merge 4 commits intoargoproj-labs:masterfrom
jgwest wants to merge 4 commits intoargoproj-labs:masterfrom
Conversation
jgwest
changed the title
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jgwest
force-pushed
the
k8s-client-wrapper-for-security-dec-2025
branch
from
ceac00c to
31a43b3
Compare
Signed-off-by: Jonathan West <jgwest@gmail.com>
jgwest
force-pushed
the
k8s-client-wrapper-for-security-dec-2025
branch
from
31a43b3 to
90360c9
Compare
akhilnittala
reviewed
Mar 6, 2026
|
|
||
| func (r *ReconcileArgoCD) internalReconcile(ctx context.Context, request ctrl.Request) (ctrl.Result, *argoproj.ArgoCD, *argoproj.ArgoCDStatus, error) { | ||
|
|
||
| reqState := &RequestState{} |
Contributor
There was a problem hiding this comment.
we can make this as part of ReconcileArgoCD struct and we can use r.reqState in struct methods? it will reduce the lines of code by passing to below functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
TBD: refactor request-scoped reconciler variables to new struct