fix(helm): correct kubectl.kubernetes.io/default-container annotation#58
Merged
ggkhrmv merged 1 commit intoargoproj-labs:mainfrom Feb 20, 2026
Conversation
Signed-off-by: Kirby Lagroix <kirby.lagroix@muckrack.com>
1d4a61f to
e2cb542
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why we need it:
Problem:
The
kubectl.kubernetes.io/default-containerPod Annotation in the helm chart has an incorrect value. Therbac-operatorvalue doesn't match any container name.Among other possible issues this could cause with
kubectl, the name mismatch causes ArgoCD to not display any logs. Error reported by ArgoCD:container rbac-operator is not valid for pod argocd-rbac-operator-9c9495f66-pgbkfFix:
Set
kubectl.kubernetes.io/default-containerto{{ .Chart.Name }}which matches the container name:argocd-rbac-operator/helm/argocd-rbac-operator/templates/deployment.yaml
Line 65 in 411ff1a
Alternatively, since there's only one container in this Pod, we could remove the annotation all together
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
N/A - I didn't file an issue
How to test changes / Special notes to the reviewer: