Skip to content

Comments

fix(helm): correct kubectl.kubernetes.io/default-container annotation#58

Merged
ggkhrmv merged 1 commit intoargoproj-labs:mainfrom
klagroix:fix/helm-incorrect-default-container-annotation
Feb 20, 2026
Merged

fix(helm): correct kubectl.kubernetes.io/default-container annotation#58
ggkhrmv merged 1 commit intoargoproj-labs:mainfrom
klagroix:fix/helm-incorrect-default-container-annotation

Conversation

@klagroix
Copy link
Contributor

What type of PR is this?
/kind bug

What does this PR do / why we need it:

Problem:
The kubectl.kubernetes.io/default-container Pod Annotation in the helm chart has an incorrect value. The rbac-operator value doesn't match any container name.

Among other possible issues this could cause with kubectl, the name mismatch causes ArgoCD to not display any logs. Error reported by ArgoCD: container rbac-operator is not valid for pod argocd-rbac-operator-9c9495f66-pgbkf

Fix:
Set kubectl.kubernetes.io/default-container to {{ .Chart.Name }} which matches the container name:

Alternatively, since there's only one container in this Pod, we could remove the annotation all together

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

N/A - I didn't file an issue

How to test changes / Special notes to the reviewer:

Signed-off-by: Kirby Lagroix <kirby.lagroix@muckrack.com>
@klagroix klagroix force-pushed the fix/helm-incorrect-default-container-annotation branch from 1d4a61f to e2cb542 Compare December 31, 2025 17:59
Copy link
Collaborator

@ggkhrmv ggkhrmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you @klagroix !

@ggkhrmv ggkhrmv merged commit 33b5d0f into argoproj-labs:main Feb 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants