Fix #680: Fail if placeholder resolves to binary data, that would break yaml#681
Open
olivergondza wants to merge 1 commit intoargoproj-labs:mainfrom
Open
Fix #680: Fail if placeholder resolves to binary data, that would break yaml#681olivergondza wants to merge 1 commit intoargoproj-labs:mainfrom
olivergondza wants to merge 1 commit intoargoproj-labs:mainfrom
Conversation
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
olivergondza
force-pushed
the
fail-on-binary
branch
from
a5736a0 to
8fda182
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fail fast if placeholder is to produce binary data. This provides better error message to diagnose misconfiguration.
Fixes: #680
Checklist
Please make sure that your PR fulfills the following requirements:
go mod tidy -compat=1.22.7to ensure only the minimum is pulled in.Type of Change
Other information