feat: Enable caching tokens for multiple vault namespaces#695
Open
DaThumpingRabbit wants to merge 1 commit intoargoproj-labs:mainfrom
Open
feat: Enable caching tokens for multiple vault namespaces#695DaThumpingRabbit wants to merge 1 commit intoargoproj-labs:mainfrom
DaThumpingRabbit wants to merge 1 commit intoargoproj-labs:mainfrom
Conversation
Signed-off-by: sbene <sebastien.bene@ubisoft.com>
65f5e0f to
d2907ea
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #695 +/- ##
==========================================
- Coverage 72.16% 71.58% -0.59%
==========================================
Files 26 29 +3
Lines 1994 2611 +617
==========================================
+ Hits 1439 1869 +430
- Misses 458 590 +132
- Partials 97 152 +55 ☔ View full report in Codecov by Sentry. |
Contributor
Author
14 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in this comment #660 (comment), the token caching strategy currently does not include support for multiple namespaces when using Vault Enterprise
Right now, it is configured to use different files per auth method and per identifier when possible (roleID for approles, username for user/pass)
With this PR, it will also include the name of the namespacxe when provided, and use
defaultwhen notChecklist
Please make sure that your PR fulfills the following requirements:
go mod tidy -compat=1.22.7to ensure only the minimum is pulled in.Type of Change