feat: Add plain text secret support for AWS Secrets Manager#711
Open
vlsi wants to merge 1 commit intoargoproj-labs:mainfrom
Open
feat: Add plain text secret support for AWS Secrets Manager#711vlsi wants to merge 1 commit intoargoproj-labs:mainfrom
vlsi wants to merge 1 commit intoargoproj-labs:mainfrom
Conversation
vlsi
force-pushed
the
aws_secretstring
branch
2 times, most recently
from
28b1586 to
9ffc89e
Compare
AWS Secrets Manager natively supports plain text secrets, but the plugin was forcing JSON parsing which caused plain text secrets to fail. This change allows retrieving plain text secrets using the SecretString key, while maintaining full backward compatibility with existing JSON and binary secret handling. Changes: - Modified GetSecrets to gracefully handle non-JSON secret strings - Added SecretString key for plain text secret access - Added comprehensive test coverage for plain text scenarios - Updated documentation with usage examples Fixes argoproj-labs#710 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>
vlsi
force-pushed
the
aws_secretstring
branch
from
9ffc89e to
cf97d7e
Compare
Author
|
A gentle ping. Could anyone please have a look over the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AWS Secrets Manager natively supports plain text secrets, but the plugin was forcing JSON parsing which caused plain text secrets to fail.
This change allows retrieving plain text secrets using the
SecretStringkey, while maintaining full backward compatibility with existing JSON and binary secret handling.AWS uses
SecretStringalready, so it sounds fair to use it for AVP as well: https://docs.aws.amazon.com/secretsmanager/latest/apireference/API_CreateSecret.htmlChanges:
Fixes: #710
Checklist
Please make sure that your PR fulfills the following requirements:
go mod tidy -compat=1.22.7to ensure only the minimum is pulled in.Type of Change
Other information
🤖 Generated with Claude Code