feat: always use ServerSideDiff when ServerSideApply is enabled #25207
+50
−245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Preview Environment undeployed from BunnyshellAvailable commands (reply to this comment):
|
2 tasks
pjiang-dev
reviewed
Nov 8, 2025
| return gvkParser | ||
| } | ||
|
|
||
| func TestStructuredMergeDiff(t *testing.T) { |
Contributor
There was a problem hiding this comment.
lets try to add equivalent tests for server side diff if we don't have them already
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Signed-off-by: Leonardo Luz Almeida <[email protected]>
Contributor
|
+1 @leoluz when do you think this will be out of draft? |
Signed-off-by: Leonardo Luz Almeida <[email protected]>
leoluz
force-pushed
the
ssd-default-for-ssa
branch
from
4cc7163 to
45e3125
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #25205
Signed-off-by: Leonardo Luz Almeida [email protected]