-
Notifications
You must be signed in to change notification settings - Fork 6.7k
docs: Update release checklist with documentation PR step #25854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Add documentation PR reminder for next minor version after RC. Signed-off-by: Revital Barletz <[email protected]>
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Signed-off-by: Revital Barletz <[email protected]>
|
@reggie-k can you take a look? |
Signed-off-by: Revital Barletz <[email protected]>
Added sections for deprecated items and upgrade instructions. Signed-off-by: Revital Barletz <[email protected]>
reggie-k
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I think that the ISSUE_TEMPLATE is mainly for creating GitHub issues,so it would be better to put this template file in another place, like a new templates folder under docs or under docs/operator-manual.
I also think it is better to put the healthcheck section at the bottom of the page as it will mostly be the longest part of the doc.
Co-authored-by: Peter Jiang <[email protected]> Signed-off-by: Revital Barletz <[email protected]>
Co-authored-by: Peter Jiang <[email protected]> Signed-off-by: Revital Barletz <[email protected]>
Co-authored-by: Peter Jiang <[email protected]> Signed-off-by: Revital Barletz <[email protected]>
Co-authored-by: Peter Jiang <[email protected]> Signed-off-by: Revital Barletz <[email protected]>
Signed-off-by: Revital Barletz <[email protected]>
Signed-off-by: Revital Barletz <[email protected]>
Updated the documentation PR template link for the next minor version in the release checklist. Signed-off-by: Revital Barletz <[email protected]>
|
Thanks @reggie-k & @pjiang-dev , I have addressed your comments, please review again. |
Add documentation PR reminder for next minor version after RC.
Fixes #25492
Checklist: